raboof commented on code in PR #950:
URL: https://github.com/apache/pekko-connectors/pull/950#discussion_r1913115079
##########
.github/workflows/check-build-test.yml:
##########
@@ -84,58 +84,58 @@ jobs:
fail-fast: false
matrix:
include:
- - { connector: amqp, pre_cmd: 'docker
compose up -d amqp' }
- - { connector: avroparquet }
- - { connector: aws-spi-pekko-http }
- - { connector: awslambda }
- - { connector: aws-event-bridge, pre_cmd: 'docker
compose up -d amazoneventbridge' }
- - { connector: azure-storage-queue }
- - { connector: cassandra, pre_cmd: 'docker
compose up -d cassandra' }
- - { connector: couchbase, pre_cmd: 'docker
compose up -d couchbase_prep' }
- - { connector: couchbase3, pre_cmd: 'docker
compose up -d couchbase_prep' }
- - { connector: csv }
- - { connector: dynamodb, pre_cmd: 'docker
compose up -d dynamodb' }
- - { connector: elasticsearch, pre_cmd: 'docker
compose up -d elasticsearch6 elasticsearch7 opensearch1' }
- - { connector: file }
- - { connector: ftp, pre_cmd:
'./scripts/ftp-servers.sh' }
- - { connector: geode, pre_cmd: 'docker
compose up -d geode' }
- - { connector: google-cloud-bigquery }
- - { connector: google-cloud-bigquery-storage }
- - { connector: google-cloud-pub-sub, pre_cmd: 'docker
compose up -d gcloud-pubsub-emulator_prep' }
- - { connector: google-cloud-pub-sub-grpc, pre_cmd: 'docker
compose up -d gcloud-pubsub-emulator_prep' }
- - { connector: google-cloud-storage }
- - { connector: google-common }
- - { connector: google-fcm }
+ - { connector: amqp, java_version: 8, pre_cmd: 'docker compose up -d
amqp' }
Review Comment:
I like how this makes sure we don't accidentally increase the required Java
version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
