raboof commented on code in PR #1505:
URL: https://github.com/apache/pekko/pull/1505#discussion_r1901943234
##########
project/PekkoDisciplinePlugin.scala:
##########
@@ -101,16 +102,18 @@ object PekkoDisciplinePlugin extends AutoPlugin {
lazy val docs =
Seq(
Compile / scalacOptions -= defaultScalaOptions.value,
- Compile / scalacOptions ++= (
- if (scalaVersion.value.startsWith("3.")) Nil
- else Seq("-Wconf:cat=unused:s,cat=deprecation:s,cat=unchecked:s,any:e")
- ),
+ Compile / scalacOptions ++=
(CrossVersion.partialVersion(scalaVersion.value).get match {
+ case (3, _) =>
Seq("-Wconf:cat=unused:s,cat=deprecation,cat=other-shadowing:s,any:e")
+ case (2, 13) =>
Seq("-Wconf:any:e,cat=unused:s,cat=deprecation:s,cat=unchecked:s")
+ case (2, 12) =>
Seq("-Wconf:cat=unused:s,cat=deprecation:s,cat=unchecked:s,any:e")
+ }),
Test / scalacOptions --= Seq("-Xlint", "-unchecked", "-deprecation"),
Test / scalacOptions -= defaultScalaOptions.value,
- Test / scalacOptions ++= (
- if (scalaVersion.value.startsWith("3.")) Nil
- else Seq("-Wconf:cat=unused:s,cat=deprecation:s,cat=unchecked:s,any:e")
- ),
+ Test / scalacOptions ++=
(CrossVersion.partialVersion(scalaVersion.value).get match {
+ case (3, _) =>
Seq("-Wconf:cat=unused:s,cat=deprecation,cat=other-shadowing:s,any:e")
+ case (2, 13) =>
Seq("-Wconf:any:e,cat=unused:s,cat=deprecation:s,cat=unchecked:s")
+ case (2, 12) =>
Seq("-Wconf:cat=unused:s,cat=deprecation:s,cat=unchecked:s,any:e")
+ }),
Review Comment:
TBH I'm OK with keeping it around until we drop support for 2.12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
