raboof commented on code in PR #1616:
URL: https://github.com/apache/pekko/pull/1616#discussion_r1894887810
##########
stream/src/main/scala/org/apache/pekko/stream/impl/PhasedFusingActorMaterializer.scala:
##########
@@ -686,6 +686,15 @@ private final case class SavedIslandData(
*/
@InternalApi private[pekko] object GraphStageTag extends IslandTag
+/**
+ * INTERNAL API
+ */
+@InternalApi
+private[pekko] object GraphStageIsland {
+ // used as a type hint when creating the array of logics
+ private final val logicArrayType = Array.empty[GraphStageLogic]
Review Comment:
`Array` is mutable, so doesn't this mean everyone shares the same `logics`?
Wouldn't that be problematic? (though it's interesting that the tests succeed)
##########
stream/src/main/scala/org/apache/pekko/stream/impl/PhasedFusingActorMaterializer.scala:
##########
@@ -695,8 +704,6 @@ private final case class SavedIslandData(
islandName: String,
subflowFuser: OptionVal[GraphInterpreterShell => ActorRef])
extends PhaseIsland[GraphStageLogic] {
- // TODO: remove these
Review Comment:
does 'these' suggests the `logics` should also be removed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
