He-Pin commented on code in PR #1593:
URL: https://github.com/apache/pekko/pull/1593#discussion_r1887247788
##########
actor/src/main/scala/org/apache/pekko/actor/LightArrayRevolverScheduler.scala:
##########
@@ -390,7 +395,19 @@ object LightArrayRevolverScheduler {
override def cancel(): Boolean = extractTask(CancelledTask) match {
case ExecutedTask | CancelledTask => false
- case _ => true
+ case task: SchedulerTask =>
+ notifyCancellation(task)
+ true
+ case _ => true
+ }
+
+ private def notifyCancellation(task: SchedulerTask): Unit = {
+ try {
+ task.cancelled()
+ } catch {
+ case Throwable =>
+ // TODO how to logging here?
Review Comment:
I think these method should run on a dedicated executor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
