pjfanning commented on code in PR #1578:
URL: https://github.com/apache/pekko/pull/1578#discussion_r1877763465
##########
cluster/src/test/scala/org/apache/pekko/cluster/protobuf/ClusterMessageSerializerSpec.scala:
##########
@@ -177,6 +177,14 @@ class ClusterMessageSerializerSpec extends
PekkoSpec("pekko.actor.provider = clu
ClusterMessageSerializer.OldWelcomeManifest)
}
+ "be de-serializable with class manifests from Akka nodes" in {
+ val oldAkkaJoinAckManifest =
s"org.apache.pekko.cluster.InternalClusterAction$$InitJoinAck"
Review Comment:
I would be worried that if we need to support the old Akka messages as well
as the newer format that changes will also need to made to toBinary too because
that would possibly leak class names with pekko package names that Akka nodes
will not understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
