raboof commented on issue #411:
URL: https://github.com/apache/pekko-grpc/issues/411#issuecomment-2472972444

   > I am not sure if they are needed
   
   They are used in 
https://github.com/apache/pekko-grpc/blob/main/gradle-plugin/src/main/groovy/org/apache/pekko/grpc/gradle/PekkoGrpcPlugin.groovy#L108
 . 
   
   > The assembly jar bundles lots of scala-library, io.grpc, guava, protobuf, 
checkerframework classes but the only LICENSE and NOTICE in the jar are copied 
from the scala-library.
   > * If we choose to keep publishing this file, we need to fix its build so 
that we add a proper LICENSE setup that properly attributes the license details 
for all classes bundled in the jar
   
   Ouch, indeed.
   
   > I don't know what the bat file is but presume it also includes compiled 
code from many sources
   
   I think it's basically the same as the assembly but wrapped in a way that 
makes it easier to execute on Windows


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org

Reply via email to