raboof commented on code in PR #241:
URL:
https://github.com/apache/pekko-connectors-kafka/pull/241#discussion_r1793067258
##########
project/Dependencies.scala:
##########
@@ -11,25 +11,18 @@ import Versions._
import sbt._
object Dependencies {
- lazy val benchmarkDependencies = Def.setting(Seq(
+ lazy val benchmarkDependencies = Seq(
"com.typesafe.scala-logging" %% "scala-logging" % "3.9.5",
"io.dropwizard.metrics" % "metrics-core" % "4.2.28",
"ch.qos.logback" % "logback-classic" % logbackVersion,
"org.slf4j" % "log4j-over-slf4j" % slf4jVersion,
"org.testcontainers" % "kafka" % testcontainersVersion % IntegrationTest,
- "org.apache.pekko" %% "pekko-slf4j" % pekkoVersion % IntegrationTest,
Review Comment:
yeah seems fine to just use `PekkoCoreDependency.version` directly there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
