mdedetrich commented on issue #1484: URL: https://github.com/apache/pekko/issues/1484#issuecomment-2355866077
To me this is acceptable as long as the number of methods we have to mark as `@noinline` is reasonable (as a rough ballback I would say < 10) and that ontop of this we also have a path forward to provide official instrumentation/hooks. The thing I want to avoid is that we make a release with a some methods marked `@noinline` and then at some point in time this isn't enough and then we end up adding even more methods with `@noinline` creating a roundabout back and forth circus. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
