JD557 commented on code in PR #592:
URL: https://github.com/apache/pekko-connectors/pull/592#discussion_r1649455255
##########
amqp/src/main/scala/org/apache/pekko/stream/connectors/amqp/AmqpConnectorSettings.scala:
##########
@@ -28,6 +28,7 @@ import scala.concurrent.duration._
sealed trait AmqpConnectorSettings {
def connectionProvider: AmqpConnectionProvider
def declarations: immutable.Seq[Declaration]
+ def avoidArrayCopy: Boolean
Review Comment:
You can also use something like `reuseByteArray` (if you want to use a
single verb instead of `avoid[Verb]`)
##########
amqp/src/main/scala/org/apache/pekko/stream/connectors/amqp/AmqpConnectorSettings.scala:
##########
@@ -28,6 +28,7 @@ import scala.concurrent.duration._
sealed trait AmqpConnectorSettings {
def connectionProvider: AmqpConnectionProvider
def declarations: immutable.Seq[Declaration]
+ def avoidArrayCopy: Boolean
Review Comment:
You can also use something like `reuseByteArray` (if you want to use a
single verb instead of `avoid[Verb]`)
(I don't have strong opinions about this, just bikeshedding)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
