raboof commented on code in PR #206:
URL:
https://github.com/apache/pekko-persistence-cassandra/pull/206#discussion_r1631974418
##########
build.sbt:
##########
@@ -43,12 +46,11 @@ lazy val core = project
lazy val cassandraLauncher = project
.in(file("cassandra-launcher"))
- .enablePlugins(Common)
+ .enablePlugins(Common, ReproducibleBuildsPlugin)
.disablePlugins(MimaPlugin)
.settings(
name := "pekko-persistence-cassandra-launcher",
- Compile / managedResourceDirectories += (cassandraBundle / target).value,
- Compile / managedResources += (cassandraBundle / Compile /
packageBin).value)
+ Compile / unmanagedResources += (cassandraBundle / Compile /
packageBin).value)
Review Comment:
This does make sense as as those build results are 'unmanaged' from the
perspective of the `cassandra-launcher` build.
I might worry sbt wouldn't correctly pick up that changes to the bundle
should trigger a rebuild of the launcher, but perhaps that's sufficiently
guaranteed since `cassandraBundle / Compile / packageBin` is still part of the
graph.
In any case I don't think we expect many changes here, and CI shows it works
well also when building 'from scratch'. I've also tried various experiments in
sbt and didn't see any new/seriously problematic behavior.
For reference: I did notice that `sbt clean` does not clear
`cassandra-bundle/target`, and it does not get rebuilt when it exists and
you're building `sbt cassandraLauncher/package`, even if you made changes to
the definition of the bundler. That was all already the case on the main
branch, though, so not a regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
