Roiocam commented on code in PR #193:
URL:
https://github.com/apache/pekko-connectors-kafka/pull/193#discussion_r1625737122
##########
.github/workflows/nightly-pekko.yml:
##########
@@ -15,65 +15,61 @@ env:
PEKKO_TEST_TIMEFACTOR: 10.0
EVENT_NAME: ${{ github.event_name }}
-jobs:
- test:
- name: Build and Test with Pekko ${{ matrix.pekko-version }}
+jobs:
+ compile-and-test:
+ name: Build and Test
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
- include:
- - { java-version: 8, scala-version: 2.12, pekko-version: '1.0.x' }
- - { java-version: 8, scala-version: 2.12, pekko-version: 'main' }
- - { java-version: 8, scala-version: 2.13, pekko-version: '1.0.x' }
- - { java-version: 8, scala-version: 2.13, pekko-version: 'main' }
- - { java-version: 8, scala-version: 3.3, pekko-version: '1.0.x' }
- - { java-version: 8, scala-version: 3.3, pekko-version: 'main' }
+ SCALA_VERSION: [2.12, 2.13, 3]
+ JDK: [8]
+ PEKKO_VERSION: ['main', '1.0.x']
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
fetch-tags: true
- - name: Checkout GitHub merge
- if: github.event.pull_request
- run: |-
- git fetch origin pull/${{ github.event.pull_request.number
}}/merge:scratch
- git checkout scratch
-
- - name: Setup Java ${{ matrix.java-version }}
+ - name: Set up JDK ${{ matrix.JDK }}
uses: actions/setup-java@v4
with:
distribution: temurin
- java-version: ${{ matrix.java-version }}
+ java-version: ${{ matrix.JDK }}
- name: Cache Coursier cache
uses: coursier/cache-action@v6
- - name: Run tests with Scala ${{ matrix.scala-version }} and Java ${{
matrix.java-version }} with Pekko ${{ matrix.pekko-version }}
- run: sbt -Dpekko.build.pekko.version=${{ matrix.pekko-version }}
"++${{ matrix.scala-version }} test"
Review Comment:
A space is missing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
