raboof commented on code in PR #1348: URL: https://github.com/apache/pekko/pull/1348#discussion_r1617050443
########## docs/src/main/paradox/stream/operators/Source-or-Flow/throttle.md: ########## @@ -41,8 +41,8 @@ Scala Java : @@snip [Throttle.java](/docs/src/test/java/jdocs/stream/operators/sourceorflow/Throttle.java) { #throttle-with-burst } -The extra argument to set the `ThrottleMode` to `shaping` tells `throttle` to make pauses to avoid exceeding -the maximum rate. Alternatively we could set the throttling mode to cause a stream failure when upstream is faster +The extra argument to set the `ThrottleMode` to `shaping` tells throttle to make pauses to avoid exceeding +the maximum rate. Alternatively we could set the `ThrottleMode` to `enforcing` cause a stream failure when upstream is faster Review Comment: ```suggestion the maximum rate. Alternatively we could set the `ThrottleMode` to `enforcing` to cause a stream failure when upstream is faster ``` ########## docs/src/main/paradox/stream/operators/Source-or-Flow/throttle.md: ########## @@ -11,7 +11,7 @@ Limit the throughput to a specific number of elements per time unit, or a specif ## Description -Limit the throughput to a specific number of elements per time unit, or a specific total cost per time unit, where +Limit the throughput to a specific number of elements per time unit, or a specific total cost per-time unit, where Review Comment: I think it really is "cost per time unit", no idea what "cost per-time unit" would mean -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org