jrudolph commented on issue #553: URL: https://github.com/apache/pekko-http/issues/553#issuecomment-2106160493
The easiest solution is to keep everything as it was because the potential performance improvements are somewhat dubious in the first place. The premise of the improved implentation is that the incoming Bytestring already is fragmented (which is not the case in the common scenario of receiving the full HEADERS frame in one go from the network). In the case that multiple Bytestringss have to be collected before header decoding, it might still be more efficient to do a compact first than iterating over the fragments (cache effects vs more complicated looping). So the only potential improvement could be removing a simple memcpy by avoiding a compact call which may or may not be a significant change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
