mdedetrich commented on PR #648: URL: https://github.com/apache/pekko-connectors/pull/648#issuecomment-2101114194
> @mdedetrich I'm thinking of just removing the integration tests. They require real AWS access. There are unit tests that use testcontainers. I think those are enough. Is this ok? So we do actually have a real AWS account that is provided by Apache INFRA and it is currently being used by [S3 tests](https://github.com/apache/pekko-connectors/blob/8c5d65051cfeb3df4a0eb87039c33131b6b21ccc/s3/src/test/scala/org/apache/pekko/stream/connectors/s3/scaladsl/S3IntegrationSpec.scala#L1267-L1282) and there is a [github action that triggers it daily off the main branch](https://github.com/apache/pekko-connectors/blob/e77bc690d85e91134c5a9571d733ea2a66c3de67/.github/workflows/nightly-builds.yaml) Initially I would suggest trying to enable the tests and if its too much effort we can disable them, file an issue and try and re-enable them later. The reason I am suggesting this is that the core reason for me pushing for the AWS S3 integration tests is we did have an actual case of a regression that wasn't caught since initially there wasn't tests running against it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
