pjfanning commented on PR #624:
URL: https://github.com/apache/pekko-connectors/pull/624#issuecomment-2068033160

   thanks - looks like a reasonable approach
   
   there are some issues
   * code doesn't compile
   ```
   [error] 
/home/runner/work/pekko-connectors/pekko-connectors/couchbase3/src/main/scala/org/apache/pekko/stream/connectors/couchbase3/scaladsl/CouchbaseSource.scala:92:49:
 too many arguments (found 2, expected 1) for method query: (x$1: 
com.couchbase.client.java.query.N1qlQuery): 
rx.Observable[com.couchbase.client.java.query.AsyncN1qlQueryResult]
   [error]       .completionStage(cluster.query(statement, options))
   [error]                                                 ^
   [error] 
/home/runner/work/pekko-connectors/pekko-connectors/couchbase3/src/main/scala/org/apache/pekko/stream/connectors/couchbase3/scaladsl/CouchbaseSource.scala:110:32:
 value analyticsQuery is not a member of com.couchbase.client.java.AsyncCluster
   [error]       .completionStage(cluster.analyticsQuery(statement, options))
   [error]     
   ```
   * scalafmt issues
   * missing Apache header on Example.scala
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to