Roiocam commented on code in PR #539:
URL: https://github.com/apache/pekko-connectors/pull/539#discussion_r1566619183
##########
project/Dependencies.scala:
##########
@@ -40,9 +40,11 @@ object Dependencies {
val hoverflyVersion = "0.14.1"
val scalaCheckVersion = "1.17.0"
- val LogbackForSlf4j1Version = "1.2.13"
- val LogbackForSlf4j2Version = "1.3.14"
- val LogbackVersion = if (PekkoBinaryVersion == "1.0")
LogbackForSlf4j1Version else LogbackForSlf4j2Version
+ // Legacy versions support Slf4J v1 for compatibility with older libs
Review Comment:
Who is dependent on Slf4J v1? Seems like slf4j2 is backward compatible.
https://www.slf4j.org/faq.html#compatibility
Should we remove logback 1.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
