samueleresca commented on code in PR #1207:
URL: https://github.com/apache/incubator-pekko/pull/1207#discussion_r1531160341
##########
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowSplitAfterSpec.scala:
##########
@@ -250,10 +248,10 @@ class FlowSplitAfterSpec extends StreamSpec("""
upstreamSubscription.sendNext(6)
substreamPuppet1.expectNext(6)
substreamPuppet1.expectComplete()
+ upstreamSubscription.sendNext(7)
Review Comment:
Thanks folks, I appreciate the detailed explanation. And yes, I was
diverting away (not on purpose) from the original goal of the test
> Note that at this point, we are dealing with the normal logic of
SplitWhen. The new functionality of skipping
> exceptions with SupervisionDecider.resume occurs earlier when elem == 3 so
we are past that and just testing happy > path logic of SplitAfter which is not
changed at all (and it shouldn't be either!).
looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
