mdedetrich commented on code in PR #1207:
URL: https://github.com/apache/incubator-pekko/pull/1207#discussion_r1529762768
##########
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowSplitAfterSpec.scala:
##########
@@ -250,10 +248,10 @@ class FlowSplitAfterSpec extends StreamSpec("""
upstreamSubscription.sendNext(6)
substreamPuppet1.expectNext(6)
substreamPuppet1.expectComplete()
+ upstreamSubscription.sendNext(7)
Review Comment:
> I was reviewing this test. Isn't the val substream2 =
subscriber.expectNext() expecting the new stream element (substream2) triggered
by the sendNext(6) instruction? why do we need to move the sendNext(7) above?
Well the test doesn't pass otherwise and if you see the equivalent tests
both in
[`FlowSplitWhenSpec`](https://github.com/apache/incubator-pekko/blob/df3b9fccde6b7fbe7829703996379a055bc27b42/stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowSplitWhenSpec.scala#L246-L278)
and
[`FlowGroupBySpec`](https://github.com/apache/incubator-pekko/blob/c44c0b7cbdab11d85176cfe062288fdcba16c56a/stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowGroupBySpec.scala#L281-L323),
its written in the same way that this PR changes it to.
There also doesn't appear to be an obvious solution to make the test as it
was originally written to pass, hence why considering everything it could just
be that the test was mistakingly written incorrectly (which is quite probably
considering the test was written just as an example, it was never
executed/passing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
