magnho commented on issue #155: URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/155#issuecomment-2003663304
@mdedetrich Sorry if I was unclear. The `.delete` is part of the `JournalDao` API, so that has to remain. I'm just questioning the implementation in `DefaultJournalDao`. It currently works like this: 1. Does an update marking all entries up to some sequence-nr as `deleted=true` in the database. 2. Does a select to get the highest sequence-nr where `deleted=true` in the db. 3. Performs the an actual delete-query up to the sequence-nr it got in step 2. This is all done in the same transaction, so the result of 1. has no effect outside of this transaction. This makes step 1 and 2 redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
