Roiocam commented on code in PR #126:
URL:
https://github.com/apache/incubator-pekko-sbt-paradox/pull/126#discussion_r1510544311
##########
theme/src/main/assets/page.st:
##########
@@ -46,7 +46,7 @@ $!
$ elseif (page.properties.("material.author")) $
<meta name="author" content="$page.properties.("site.author")$">
$ endif $
- <link rel="shortcut icon"
href="$page.base$$page.properties.("material.favicon")$">
+ <link rel="shortcut icon"
href="$page.properties.("assets.hostname")$$page.base$$page.properties.("material.favicon")$">
Review Comment:
> The link is to
https://pekko.apache.org/docs/pekko-http/current/assets/images/pekko_logo.png
>
> Should be https://pekko.apache.org/assets/images/pekko_logo.png
The previous comments should be no problem. `$page.base$` is not a problem.
At present, it is always the root directory of the project, that is.
The documents generated by all these modules (http, connector, pekko) are
"assets/xxxx", even if the string template adds `assets.home`, but due to
pekko, conn Ector These modules do not have the default value of `assets.home`,
so they still do not point the path to CDN.
So I think the PR needs to set a default value for assets.home, or
explicitly add the assets.home configuration value for each project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
