He-Pin commented on code in PR #1155:
URL: https://github.com/apache/incubator-pekko/pull/1155#discussion_r1503903719
##########
project/PekkoDisciplinePlugin.scala:
##########
@@ -74,16 +74,19 @@ object PekkoDisciplinePlugin extends AutoPlugin {
"pekko-stream-tests-tck",
"pekko-testkit")
- val defaultScalaOptions = "-Wconf:cat=unused-nowarn:s,any:e"
+ lazy val defaultScalaOptions =
Def.setting(CrossVersion.partialVersion(scalaVersion.value) match {
+ case Some((2, 12)) => "-Wconf:cat=unused-nowarn:s,any:e"
+ case _ =>
"-Wconf:cat=unused-nowarn:s,cat=lint-named-booleans:s,cat=other-shadowing:s,any:e"
Review Comment:
Possible, but then need to change a lot of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
