mdedetrich commented on code in PR #1137: URL: https://github.com/apache/incubator-pekko/pull/1137#discussion_r1502253422
########## remote/src/main/scala/org/apache/pekko/remote/PhiAccrualFailureDetector.scala: ########## @@ -119,7 +117,8 @@ class PhiAccrualFailureDetector( private val acceptableHeartbeatPauseMillis = acceptableHeartbeatPause.toMillis // address below was introduced as a var because of binary compatibility constraints Review Comment: Can we prefix this comment with `NOTE` so that its easily searchable. Should also make a pekko issue to make this a non var targeting Pekko 2.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
