pjfanning commented on code in PR #97:
URL: 
https://github.com/apache/incubator-pekko-sbt-paradox/pull/97#discussion_r1490140842


##########
.github/workflows/ci.yml:
##########
@@ -45,33 +45,79 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Setup Java (temurin@11)
-        if: matrix.java == 'temurin@11'
+      - name: Setup Java (temurin@8)
+        if: matrix.java == 'temurin@8'
         uses: actions/setup-java@v4
         with:
           distribution: temurin
-          java-version: 11
+          java-version: 8
           cache: sbt
 
-      - name: Setup Java (temurin@17)
-        if: matrix.java == 'temurin@17'
-        uses: actions/setup-java@v4
+      - name: Check that workflows are up to date
+        shell: bash
+        run: sbt '++ ${{ matrix.scala }}' githubWorkflowCheck
+
+      - shell: bash
+        run: sbt '++ ${{ matrix.scala }}' test scripted
+
+      - name: Compress target directories
+        shell: bash
+        run: tar cf targets.tar target theme/target plugin/target 
project/target
+
+      - name: Upload target directories
+        uses: actions/upload-artifact@v4
         with:
-          distribution: temurin
-          java-version: 17
-          cache: sbt
+          name: target-${{ matrix.os }}-${{ matrix.scala }}-${{ matrix.java }}
+          path: targets.tar
+
+  publish:
+    name: Publish Artifacts
+    needs: [build]
+    if: github.event_name != 'pull_request' && (github.ref == 
'refs/heads/main')
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+        scala: [2.12.18]
+        java: [temurin@8]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - name: Ignore line ending differences in git
+        if: contains(runner.os, 'windows')
+        run: git config --global core.autocrlf false
 
-      - name: Setup Java (temurin@21)
-        if: matrix.java == 'temurin@21'
+      - name: Configure pagefile for Windows
+        if: contains(runner.os, 'windows')
+        uses: al-cheb/configure-pagefile-action@v1.4

Review Comment:
   why all this windows stuff? not a blocker



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org

Reply via email to