Roiocam commented on code in PR #1065: URL: https://github.com/apache/incubator-pekko/pull/1065#discussion_r1469844835
########## project/Jdk9PackageCheck.scala: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import Jdk9.CompileJdk9 +import sbt.AutoPlugin +import sbt.Def +import sbt.Keys._ +import sbt._ +import sbt.internal.BuildStructure + +object Jdk9PackageCheck extends AutoPlugin { + + object autoImport { + lazy val jdk9Check = taskKey[Unit]("Report which jars are in each scope.") + } + + import autoImport._ + + override lazy val trigger = NoTrigger + override lazy val requires = Jdk9 + val validScopeKey = (Compile / packageBin).scopedKey + + def scopedKeyMatch(scopedKey: ScopedKey[_], projectRef: ProjectRef): Boolean = { + if (scopedKey.key != validScopeKey.key || scopedKey.scope.config != validScopeKey.scope.config) + return false + + scopedKey.scope.project match { + case Select(s) => s == projectRef + case _ => false + } + } + + def hasJdk9Config(set: Set[_ <: sbt.ScopedKey[_]])(implicit cMap: Map[Def.ScopedKey[_], Def.Flattened]): Boolean = { + set.exists { key => + key.scope.config match { + case Select(s) if s.name == CompileJdk9.name => true Review Comment: I have upgraded this to use a plugin rather than code, can you take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
