Roiocam commented on code in PR #1078:
URL: https://github.com/apache/incubator-pekko/pull/1078#discussion_r1469453020
##########
project/VerifyJDK9Classes.scala:
##########
@@ -22,24 +22,23 @@ object VerifyJDK9Classes {
lazy val settings: Seq[Setting[_]] = inConfig(Compile) {
Seq {
sourceGenerators += {
- generateAndWriteScalaCLIScript(
- target,
- _ / "scala-cli" / "VerifyJDK9Classes.sc")
+ generateAndWriteScalaCLIScript(target)
Review Comment:
More readable!
##########
.github/workflows/verify-jdk9-classes.sh:
##########
@@ -0,0 +1,18 @@
+#!/bin/bash
+
+echo "Checking Scala CLI version..."
+scala-cli --version
+
+echo "Starting verification with Scala-CLI..."
+
+for file in stream/target/scala-cli/*.sc; do
Review Comment:
Cool, has expandable capability.
##########
.github/workflows/nightly-builds.yml:
##########
@@ -181,19 +181,15 @@ jobs:
"+~ ${{ matrix.scalaVersion }} publishLocal publishM2"
- name: Install scala-cli
- if: ${{ contains('11,17,21', matrix.javaVersion) }}
+ if: ${{ matrix.javaVersion == 11 }}
run: |-
curl -sS "https://virtuslab.github.io/scala-cli-packages/KEY.gpg"; |
sudo gpg --dearmor -o /etc/apt/trusted.gpg.d/scala-cli.gpg 2>/dev/null
sudo curl -s --compressed -o
/etc/apt/sources.list.d/scala_cli_packages.list
"https://virtuslab.github.io/scala-cli-packages/debian/scala_cli_packages.list";
sudo apt update
sudo apt install scala-cli
- name: Use Scala-CLI to verify jdk 9 classes
- if: ${{ contains('11,17,21', matrix.javaVersion) }}
+ if: ${{ matrix.javaVersion == 11 }}
run: |-
- scala-cli --version
- echo "Starting verification with Scala-CLI"
- scala-cli stream/target/scala-cli/VerifyJDK9Classes.sc && echo
"Verification successful" || (
- echo "Error when VerifyJDK9Classes"
- exit 1
- )
+ chmod +x .github/workflows/verify-jdk9-classes.sh
+ .github/workflows/verify-jdk9-classes.sh
Review Comment:
```suggestion
sh github/workflows/verify-jdk9-classes.sh
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
