pjfanning commented on code in PR #942:
URL: https://github.com/apache/incubator-pekko/pull/942#discussion_r1451734243
##########
stream/src/main/scala/org/apache/pekko/stream/scaladsl/Flow.scala:
##########
@@ -181,7 +182,22 @@ final class Flow[-In, +Out, +Mat](
* '''Cancels when''' original [[Flow]] cancels
*/
def contramap[In2](f: In2 => In): Flow[In2, Out, Mat] =
- Flow.fromFunction(f).viaMat(this)(Keep.right)
+
Flow.fromFunction(f).viaMat(this)(Keep.right).withAttributes(DefaultAttributes.contramap)
+
+ /**
+ * Transform this Flow by applying a function `f` to each *incoming*
upstream element before
+ * it is passed to the [[Flow]], and a function `g` to each *outgoing*
downstream element.
+ *
+ * '''Emits when''' the mapping function `g` returns an element
+ *
+ * '''Backpressures when''' original [[Flow]] backpressures
+ *
+ * '''Completes when''' original [[Flow]] completes
+ *
+ * '''Cancels when''' original [[Flow]] cancels
Review Comment:
again, please add `@since` to new methods/functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
