He-Pin commented on code in PR #314:
URL:
https://github.com/apache/incubator-pekko-connectors/pull/314#discussion_r1451710311
##########
google-common/src/main/scala/org/apache/pekko/stream/connectors/google/auth/GoogleOAuth2.scala:
##########
@@ -37,7 +37,7 @@ private[auth] object GoogleOAuth2 {
private val oAuthTokenUrl = "https://oauth2.googleapis.com/token";
- def getAccessToken(clientEmail: String, privateKey: String, scopes:
Seq[String])(
+ def getAccessToken(clientEmail: String, privateKey: String, scopes:
Set[String])(
Review Comment:
I think a mina filter will be needed. or add an overloaded method which use
seq.toSet then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
