micafer commented on PR #2058: URL: https://github.com/apache/libcloud/pull/2058#issuecomment-3890454995
Thanks for your contribution, and sorry for de delay in the review. I have some comments: In s3.py and azure_blobs.py: ex_method is Literal["GET", "PUT", "DELETE"] but in In ovh.py and scaleway.py: ex_method is str This should be consistent across all drivers. I recommend using Literal. In azure_blobs.py, the docstring does not document the new ex_method parameter. In s3.py, the docstring does not document the new parameter. In ovh.py and scaleway.py, the docstring has not been updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
