Kami commented on code in PR #1996:
URL: https://github.com/apache/libcloud/pull/1996#discussion_r1564898554


##########
libcloud/storage/drivers/s3.py:
##########
@@ -1435,6 +1395,17 @@ class S3EUWest2StorageDriver(S3StorageDriver):
     region_name = "eu-west-2"
 
 
+class S3EUWest3Connection(S3SignatureV4Connection):

Review Comment:
   Those two classes are actually not needed anymore - this was an old approach 
(class per region) which is not used anymore and has been replaced via `region` 
class constructor argument.
   
   Can you please remove them? Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to