displague commented on code in PR #1971:
URL: https://github.com/apache/libcloud/pull/1971#discussion_r1388307253


##########
libcloud/compute/drivers/equinixmetal.py:
##########
@@ -701,246 +703,14 @@ def ex_disassociate_address(self, address_uuid, 
include=None):
         result = self.connection.request(path, params=params, 
method="DELETE").object
         return result
 
-    def list_volumes(self, ex_project_id=None):

Review Comment:
   I can confirm that the Storage APIs have been sunset since June 2021. There 
is no direct alternative to this service.



##########
libcloud/compute/drivers/equinixmetal.py:
##########
@@ -491,7 +493,7 @@ def _to_size(self, data):
         except KeyError:
             cpus = None
         regions = [
-            region.get("href").replace("/metal/v1/facilities/", "")
+            region.get("href").replace("/metal/v1/metros/", "")

Review Comment:
   I confirmed that `href` is returned with each metro and they follow the 
`/metal/v1/locations/metros/{uuid}` pattern.
   
   When getting the plans list, if `?include=available_in_metros` is supplied, 
`href` will be omitted in the available_in_metros list of objects. These will 
contain id, name, code, country, and `price` (object with `hour` rate).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to