vicwicker opened a new pull request, #1954: URL: https://github.com/apache/libcloud/pull/1954
## Changes Title (replace this with a logical title for your changes) ### Description As per documentation [1], the InnerIpAddress field is only relevant when the node network type is set to classic. If the node is within a VPC, the private IP is returned by the VpcAttributes/PrivateIpAddress. In addition, elastic IPs in field EipAddress are also public ips. They differ from other public IPs in that they are static and stay the same once allocated. Fields EipAddress and VpcAttributes are already returned in the response as part of the "extra" field of the node object. This is however not consistent with other drivers as these fields are also public and private IP addresses, respectively. [1] https://www.alibabacloud.com/help/en/ecs/developer-reference/api-describeinstances ### Status - done, ready for review ### Checklist (tick everything that applies) - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks) - [x] Documentation - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html) - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
