Kami commented on code in PR #1950:
URL: https://github.com/apache/libcloud/pull/1950#discussion_r1324930081
##########
libcloud/storage/drivers/s3.py:
##########
@@ -1458,6 +1460,14 @@ class S3EUNorth1StorageDriver(S3StorageDriver):
ex_location_name = "eu-north-1"
region_name = "eu-north-1"
+class S3EUSouth1Connection(S3SignatureV4Connection):
Review Comment:
There is no need anymore to define a class per region. A long time ago we
moved away from a class per region to `region` constructor argument approach.
Other classes were just left in places for backward compatibility reasons.
Just adding an entry to `REGION_TO_HOST_MAP` dictionary is sufficient.
https://github.com/apache/libcloud/blob/9756484101d6570f03542288d2f38fdb381500d1/libcloud/storage/drivers/s3.py#L1253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
