Kami commented on PR #1940: URL: https://github.com/apache/libcloud/pull/1940#issuecomment-1682859622
Thanks for the contribution. The original logic indeed looks weird / wrong, but I didn't originally implement the code and I'm not sure about the logic and the reasoning behind it. Having said that, some tests for that logic (including various edge cases) would be a good start (and of course making sure that existing tests / if any, still pass). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
