This is an automated email from the ASF dual-hosted git repository.

tomaz pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/libcloud.git

commit 831d7a160309ee2a91d37256c5e28e360837e707
Author: Tomaz Muraus <to...@tomaz.me>
AuthorDate: Mon Jul 31 17:20:22 2023 +0200

    Fix mypy violations due to the breaking change in the new version which
    changed the default value from no_implicit_optional = false to
    no_implicit_optional = true.
---
 libcloud/common/types.py   |  2 +-
 libcloud/compute/base.py   | 24 ++++++++++++------------
 libcloud/container/base.py |  8 ++++----
 libcloud/dns/base.py       |  6 +++---
 4 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/libcloud/common/types.py b/libcloud/common/types.py
index c5b1732cf..673e0d9d7 100644
--- a/libcloud/common/types.py
+++ b/libcloud/common/types.py
@@ -89,7 +89,7 @@ class LibcloudError(Exception):
     """The base class for other libcloud exceptions"""
 
     def __init__(self, value, driver=None):
-        # type: (str, BaseDriver) -> None
+        # type: (str, Optional[BaseDriver]) -> None
         super().__init__(value)
         self.value = value
         self.driver = driver
diff --git a/libcloud/compute/base.py b/libcloud/compute/base.py
index ac22a2d3c..7ec7772c1 100644
--- a/libcloud/compute/base.py
+++ b/libcloud/compute/base.py
@@ -118,8 +118,8 @@ class UuidMixin:
     Mixin class for get_uuid function.
     """
 
-    def __init__(self):
-        self._uuid = None  # type: str
+    def __init__(self) -> None:
+        self._uuid = None  # type: Optional[str]
 
     def get_uuid(self):
         """
@@ -208,10 +208,10 @@ class Node(UuidMixin):
         public_ips,  # type: List[str]
         private_ips,  # type: List[str]
         driver,
-        size=None,  # type: NodeSize
-        image=None,  # type: NodeImage
-        extra=None,  # type: dict
-        created_at=None,  # type: datetime.datetime
+        size=None,  # type: Optional[NodeSize]
+        image=None,  # type: Optional[NodeImage]
+        extra=None,  # type: Optional[dict]
+        created_at=None,  # type: Optional[datetime.datetime]
     ):
         """
         :param id: Node ID.
@@ -500,7 +500,7 @@ class NodeImageMember(UuidMixin):
         image_id,  # type: str
         state,  # type: NodeImageMemberState
         driver,  # type: NodeDriver
-        created=None,  # type: datetime.datetime
+        created=None,  # type: Optional[datetime.datetime]
         extra=None,  # type: Optional[dict]
     ):
         """
@@ -755,10 +755,10 @@ class VolumeSnapshot:
         self,
         id,  # type: str
         driver,  # type: NodeDriver
-        size=None,  # type: int
+        size=None,  # type: Optional[int]
         extra=None,  # type: Optional[Dict]
         created=None,  # type: Optional[datetime.datetime]
-        state=None,  # type: StorageVolumeState
+        state=None,  # type: Optional[StorageVolumeState]
         name=None,  # type: Optional[str]
     ):
         # type: (...) -> None
@@ -935,7 +935,7 @@ class NodeDriver(BaseDriver):
         size,  # type: NodeSize
         image,  # type: NodeImage
         location=None,  # type: Optional[NodeLocation]
-        auth=None,  # type: T_Auth
+        auth=None,  # type: Optional[T_Auth]
     ):
         # type: (...) -> Node
         """
@@ -1028,11 +1028,11 @@ class NodeDriver(BaseDriver):
         ssh_timeout=10,  # type: int
         ssh_key=None,  # type: Optional[T_Ssh_key]
         ssh_key_password=None,  # type: Optional[str]
-        auth=None,  # type: T_Auth
+        auth=None,  # type: Optional[T_Auth]
         timeout=SSH_CONNECT_TIMEOUT,  # type: int
         max_tries=3,  # type: int
         ssh_interface="public_ips",  # type: str
-        at_exit_func=None,  # type: Callable
+        at_exit_func=None,  # type: Optional[Callable]
         wait_period=5,  # type: int
         **create_node_kwargs,
     ):
diff --git a/libcloud/container/base.py b/libcloud/container/base.py
index 1ec7148ed..b684a6d4e 100644
--- a/libcloud/container/base.py
+++ b/libcloud/container/base.py
@@ -41,8 +41,8 @@ class Container:
         state,  # type: ContainerState
         ip_addresses,  # type: List[str]
         driver,  # type: ContainerDriver
-        extra=None,  # type: dict
-        created_at=None,  # type: str
+        extra=None,  # type: Optional[dict]
+        created_at=None,  # type: Optional[str]
     ):
         """
         :param id: Container id.
@@ -112,7 +112,7 @@ class ContainerImage:
         path,  # type: str
         version,  # type: str
         driver,  # type: ContainerDriver
-        extra=None,  # type: dict
+        extra=None,  # type: Optional[dict]
     ):
         """
         :param id: Container Image id.
@@ -164,7 +164,7 @@ class ContainerCluster:
         id,  # type: str
         name,  # type: str
         driver,  # type: ContainerDriver
-        extra=None,  # type: dict
+        extra=None,  # type: Optional[dict]
     ):
         """
         :param id: Container Image id.
diff --git a/libcloud/dns/base.py b/libcloud/dns/base.py
index a358b9229..f87844744 100644
--- a/libcloud/dns/base.py
+++ b/libcloud/dns/base.py
@@ -36,7 +36,7 @@ class Zone:
         type,  # type: str
         ttl,  # type: int
         driver,  # type: DNSDriver
-        extra=None,  # type: dict
+        extra=None,  # type: Optional[dict]
     ):
         """
         :param id: Zone id.
@@ -116,8 +116,8 @@ class Record:
         data,  # type: str
         zone,  # type: Zone
         driver,  # type: DNSDriver
-        ttl=None,  # type: int
-        extra=None,  # type: dict
+        ttl=None,  # type: Optional[int]
+        extra=None,  # type: Optional[dict]
     ):
         """
         :param id: Record id

Reply via email to