Kami commented on code in PR #1796:
URL: https://github.com/apache/libcloud/pull/1796#discussion_r1045101820
##########
libcloud/common/base.py:
##########
@@ -527,6 +527,7 @@ def request(
stream=False,
json=None,
retry_failed=None,
+ container=None,
Review Comment:
Overall, the changes except this one look good to me.
I don't think we should add ``container`` argument this function since it's
a generic function not tied to any specific API so we should create a
dependency on the storage API / container argument here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
