Kami commented on code in PR #1807:
URL: https://github.com/apache/libcloud/pull/1807#discussion_r1039983934
##########
libcloud/common/google.py:
##########
@@ -480,6 +482,62 @@ def refresh_token(self, token_info):
new_token["refresh_token"] = token_info["refresh_token"]
return new_token
+ @property
+ def _redirect_uri_with_port(self):
+ return self.redirect_uri + ":" + str(self.redirect_uri_port)
+
+ def _receive_code_through_local_loopback(self):
Review Comment:
It would be great if you could add a test case for this method. I know it's
a bit more involved to test the whole method, but IIRC we already have existing
patterns with mock http server and threads in some places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
