Kami commented on PR #1736:
URL: https://github.com/apache/libcloud/pull/1736#issuecomment-1235829430
As far as your two questions go:
> I have also merged the disk API versions because the zones parameter was
only supported in newer API versions. I do not fully understand the impact of
bumping the API versions, but if tests pass, I think it should be fine.
Thoughts?
Integration tests would increase the confidence here, but sadly we don't
have integration tests for Azure ARM.
> The new API version also caused request and response payloads to differ
i.e. the volume types are now passed as
[DiskSku](https://docs.microsoft.com/en-us/rest/api/compute/disks/create-or-update?tabs=HTTP#disksku)
objects instead of strings. How do we handle API changes? Is there
documentation around making such API changes?
One option would be to allow user to pass ``api_version`` or similar
argument to the constructor and then when user specifies a new version which
uses new ``DISK_API_VERSION`` value, otherwise it would default to the previous
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
