Kami commented on PR #1715:
URL: https://github.com/apache/libcloud/pull/1715#issuecomment-1193116027
I've pushed some small lint and ``tox.ini`` fixes, but it looks like the
script still fails with empty cache:
```
Traceback (most recent call last):
File "contrib/scrape-ec2-prices.py", line 301, in <module>
main()
File "contrib/scrape-ec2-prices.py", line 294, in main
pricing_data = scrape_ec2_pricing()
File "contrib/scrape-ec2-prices.py", line 137, in scrape_ec2_pricing
prices = get_all_prices()
File "contrib/scrape-ec2-prices.py", line 104, in get_all_prices
with open(json_file, 'r') as f:
TypeError: expected str, bytes or os.PathLike object, not tuple
```
I pushed a small fix for that, but didn't have time to dig in if there are
other issues present.
On top of that, it looks like script takes a very long time to complete even
when cache is available (I never got it to finish - not sure if it just takes a
really long time or there is an infinite loop or similar).
What kind of run times have you seen on your computer?
If it takes a really long time, it might also not be a bad idea to add some
kind of basic progress bar (e.g. print "." every now and then to give some
feedback that script didn't get stuck or even better, periodically print how
many items we have processed so far out of the total number).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
