GitHub user gargpankaj83 opened a pull request:
https://github.com/apache/libcloud/pull/1073
Using ConnectionUserAndKey class as ConnectionCls
## Using ConnectionUserAndKey class as ConnectionCls
### DigitalOcean uses ConnectionKey class to establish connection but
passes userid. Docker uses ConnectionUserAndKey however, for the insecure
connection, the used is not passed and hence connection fails.
### Status
Replace this: describe the PR status. Examples:
- done, ready for review
### Checklist (tick everything that applies)
- [ ] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gargpankaj83/libcloud trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1073.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1073
----
commit b1f249bf3c3d05ab4a8a250eca9b9512d7c27217
Author: Pankaj Garg <[email protected]>
Date: 2017-06-15T07:16:24Z
Issue LIBCLOUD-920: passing empty request body
commit 4472a1a718f51ffa1c9df8d41ecb646d4f24444a
Author: Pankaj Garg <[email protected]>
Date: 2017-06-16T10:26:22Z
Using ConnectionUserAndKey instead of ConnectionKey to handle the insecure
connections
commit d06888d261fa57a10ece5401d6f57fc89176a5f0
Author: Pankaj Garg <[email protected]>
Date: 2017-06-16T10:34:47Z
Merge branch 'trunk' into
LIBCLOUD-921_fix_crash_for_insecure_docker_engine_connection
commit 88e5a375db878f3d7b45106d048ca2aae5bda10a
Author: Pankaj Garg <[email protected]>
Date: 2017-06-16T18:20:24Z
adding secret to the args when required
commit e91d381ef8aade28bb5b26a785be475f1a5c8b61
Author: Pankaj Garg <[email protected]>
Date: 2017-06-16T18:20:49Z
Merge branch 'trunk' into
LIBCLOUD-921_fix_crash_for_insecure_docker_engine_connection
commit 80b1a79dcf1f06a78d19df19c1949b9b9650ead0
Author: Pankaj Garg <[email protected]>
Date: 2017-06-19T06:15:22Z
merged from apach origin trunk
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
