GitHub user jhelie opened a pull request:
https://github.com/apache/libcloud/pull/1063
fix 1 lgtm.com alert
Fix 1 lgtm.com alert
### Description
Hi,
Just wanted to quickly fix this alert that is flagged up on lgtm.com.
`ResourceNotFoundError` is a subclass of `GoogleBasError` so the ordering
of the except blocks would have never allowed to reach it.
If the previous behaviour was satisfactory the the `ResourceNotFoundError`
block should be deleted.
Hope this helps!
A total of 162 alerts have been flagged up by lgtm.com, you can enable pull
request integration for fully automated PR reviews that will flag these in the
future so that they don't get past code review.
https://lgtm.com/projects/g/apache/libcloud/alerts/
### Status
done, ready for review
### Checklist (tick everything that applies)
- [ X] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jhelie/libcloud fix-lgtm-alert
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1063.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1063
----
commit b01cab87b1580fdafe54059c3a6b0b5a78bd36ef
Author: jhelie <[email protected]>
Date: 2017-05-26T11:03:35Z
fix unreachable except block
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
