[
https://issues.apache.org/jira/browse/LIBCLOUD-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497224#comment-15497224
]
ASF GitHub Bot commented on LIBCLOUD-852:
-----------------------------------------
GitHub user jbmchuck opened a pull request:
https://github.com/apache/libcloud/pull/859
[LIBCLOUD-852] Support filtering in ec2 list_volumes
## Support filtering in EC2 list_volumes
### Description
There currently is not a way to filter volumes in the EC2 driver
list_volumes. This is a useful feature for identifying volumes with certain
attributes - e.g. orphaned volumes. The filtering param is already implicitly
used in list_volumes to specify an attached instance-id, if node arg is
provided. This change allows additional explicit filters to be provided.
The particular issue I have run into motivating this change is - if I
create a volume using create_volume and immediately attach it to a node using
attach_volume I occasionally run into errors where the volume was created but
is not yet ready for attachment. I can use list_volumes to fetch everything
and filter on my end, but I'd rather filter server side as I am with
list_images and other similar functions.
I also added a docstring.
### Status
done, ready for review
### Checklist (tick everything that applies)
- [x] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [x] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbmchuck/libcloud
LIBCLOUD-852_list_volume_filters
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/859.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #859
----
commit cc33fc23fdd271b83567e3149c698ea6a9c4e612
Author: Michaelchuck, Jon (DS) <[email protected]>
Date: 2016-09-16T19:48:17Z
[LIBCLOUD-852] Support filtering in ec2 list_volumes
----
> Support filters in BaseEC2NodeDriver.list_volumes
> -------------------------------------------------
>
> Key: LIBCLOUD-852
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-852
> Project: Libcloud
> Issue Type: Improvement
> Components: Compute
> Reporter: Jonathan Michaelchuck
> Priority: Minor
>
> Several ec2 functions allow ex_filters to be specified, however list_volumes
> does not, it would be a helpful improvement in several cases - for instance,
> determining if a recently added volume is ready to be attached, identifying
> orphaned volumes, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
