Repository: libcloud Updated Branches: refs/heads/trunk 0dced6dae -> 2d4a6d32d
CloudStack: Values with wildcards will fail signature validation Thanks to a small bug in the request signer the signature will be invalid for any request with any value containing a wildcard. Identical to https://github.com/apache/cloudstack-cloudmonkey/commit/38b68fbe0bf9a4bea1836bba55be57928ef74cee Closes #846 Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/61d3bdbe Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/61d3bdbe Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/61d3bdbe Branch: refs/heads/trunk Commit: 61d3bdbecd25c556758a4df92253ca38f845a1f9 Parents: 0dced6d Author: Ronald van Zantvoort <[email protected]> Authored: Mon Aug 1 22:44:57 2016 +0200 Committer: Anthony Shaw <[email protected]> Committed: Tue Aug 9 09:12:25 2016 +1000 ---------------------------------------------------------------------- libcloud/common/cloudstack.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/libcloud/blob/61d3bdbe/libcloud/common/cloudstack.py ---------------------------------------------------------------------- diff --git a/libcloud/common/cloudstack.py b/libcloud/common/cloudstack.py index c40ed0f..ee16dfd 100644 --- a/libcloud/common/cloudstack.py +++ b/libcloud/common/cloudstack.py @@ -80,7 +80,7 @@ class CloudStackConnection(ConnectionUserAndKey, PollingConnection): pairs = [] for pair in signature: key = urlquote(str(pair[0]), safe='[]') - value = urlquote(str(pair[1]), safe='[]') + value = urlquote(str(pair[1]), safe='[]*') item = '%s=%s' % (key, value) pairs .append(item)
