GitHub user Katana-Steel opened a pull request:
https://github.com/apache/libcloud/pull/838
Libvirt/libvirt node driver cleanup and tests
## Extra tests for libvirt_driver and driver creation clean up
### Description
Code clean up and added more tests for the libvirt_driver module.
Cleaner driver creation with less console output when using SASL
authentication.
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [X] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [X] Documentation
- [X] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Katana-Steel/libcloud
libvirt/LibvirtNodeDriver_cleanup_and_tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/838.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #838
----
commit 2461f98350cb7337459343483582447b022d380f
Author: Rene Kjellerup <rkjelle...@touchcommerce.com>
Date: 2016-07-08T18:49:33Z
cleaned up LibvirtNodeDriver.__init__
checking the uri string for +tcp before trying to do the SASL
connection to the libvirtd service
commit 3fc4a12b8e326abb96561723b94b7a7cd8053e96
Author: Rene Kjellerup <rkjelle...@touchcommerce.com>
Date: 2016-07-09T00:07:14Z
adding more tests, and cleaning up the mock setup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
