[ 
https://issues.apache.org/jira/browse/LIBCLOUD-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353933#comment-14353933
 ] 

ASF GitHub Bot commented on LIBCLOUD-676:
-----------------------------------------

GitHub user jlk opened a pull request:

    https://github.com/apache/libcloud/pull/482

    LIBCLOUD-676: Allow describing AMI tags

    Per the referenced Jira - I can't think of a reason for why 
ex_describe_tags() shouldn't be able to be used for other resources besides 
instances and storage, so removed the filter.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jlk/libcloud trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/482.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #482
    
----
commit aaa518aff4283d51c063316ee1c79d3c0b102432
Author: John Kinsella <[email protected]>
Date:   2015-03-09T23:57:39Z

    LIBCLOUD-676: Allow describing AMI tags
    
    Removed filter that only allows returning tags for ec2 instances

----


> ex_describe_tags shows results for instances only
> -------------------------------------------------
>
>                 Key: LIBCLOUD-676
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-676
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>            Reporter: John Kinsella
>
> While AWS EC2 describe-tags API will return tags for any resource with tags, 
> the libcloud ex_describe_tags() will not.
> Looking at the code, ex_describe_tags() calls ec2's DescribeTags with a 
> filter of "'resource-type': 'instance'"
> I've looked through commits on ec2.py - I don't see a reason (historical or 
> otherwise) for having ex_describe_tags not work on all ec2 resources?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to