GitHub user raphtheb opened a pull request:
https://github.com/apache/libcloud/pull/353
[LIBCLOUD-544] Resolve a bug introduced by the original fix of the issue...
This is meant to replace github.com/apache/libcloud/pull/349
With one clean commit.
1- Add separated verifications for "None" and malformed metadata.
A clear error will be raised upon malformed metadata.
If undefined or already None, we assume None.
2- Provide comments explaining the odd GCE dictionary format.
3- Perform check on metadata dictionary structure. We expect one "items" key
and a tuple of arbitrary values.
4- Prefix the keys/values provided by a simple dictionary by "items" if not
found, enforcing point 3's structure.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/raphtheb/libcloud
LIBCLOUD-544_gce_metadata_squashed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/353.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #353
----
commit 652f59aa3747ce78f6db5b82097ce8ded3c4e6d4
Author: rtheberge <[email protected]>
Date: 2014-08-29T13:41:14Z
[LIBCLOUD-544] Resolve a bug introduced by the original fix of the issue.
1- Add separated verifications for "None" and malformed metadata.
A clear error will be raised upon malformed metadata.
If undefined or already None, we assume None.
2- Provide comments explaining the odd GCE dictionary format.
3- Perform check on metadata dictionary structure. We expect one "items" key
and a tuple of arbitrary values.
4- Prefix the keys/values provided by a simple dictionary by "items" if not
found, enforcing point 3's structure.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
