[
https://issues.apache.org/jira/browse/LIBCLOUD-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049944#comment-14049944
]
ASF GitHub Bot commented on LIBCLOUD-592:
-----------------------------------------
GitHub user zerthimon opened a pull request:
https://github.com/apache/libcloud/pull/334
[LIBCLOUD-592] Create a generic method for listing AWS EIPs
Currently there are three methods in ec2 driver for listing EIPs:
They all satisfy different use cases:
ex_describe_all_addresses() - list all EIPs (vpc and ec2) optionally list
only associated EIPs.
ex_describe_addresses() - list only EIPs for the specific nodes.
ex_describe_addresses_for_node() - list only EIPs for specific node.
This PR creates a generic method ex_list_addresses() to give users more
flexibility while listing EIPs, by implementing all the functionality from this
API call:
http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-DescribeAddresses.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zerthimon/libcloud
LIBCLOUD-592_generic_method_for_listing_AWS_EIPs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #334
----
commit 7d1d2be18135435588928a8122c56aa96896c6b5
Author: Lior Goikhburg <goikhb...@gmail.com>
Date: 2014-07-02T14:18:00Z
[LIBCLOUD-592] Create a generic method for listing AWS EIPs
----
> Create a generic method for listing AWS EIPs
> --------------------------------------------
>
> Key: LIBCLOUD-592
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-592
> Project: Libcloud
> Issue Type: Improvement
> Reporter: Lior Goikhburg
> Priority: Minor
>
> Currently there are three methods in ec2 driver for listing EIPs:
> They all satisfy different use cases:
> ex_describe_all_addresses() - list all EIPs (vpc and ec2) optionally list
> only associated EIPs.
> ex_describe_addresses() - list only EIPs for the specific nodes.
> ex_describe_addresses_for_node() - list only EIPs for specific node.
> Create a generic method ex_list_addresses() to give users more flexibility
> while listing EIPs, by implementing all the functionality from this API call:
> http://docs.aws.amazon.com/AWSEC2/latest/APIReference/ApiReference-query-DescribeAddresses.html
--
This message was sent by Atlassian JIRA
(v6.2#6252)
