wayne-x-wang commented on code in PR #7793: URL: https://github.com/apache/kyuubi/pull/7793#discussion_r4345976358
########## externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/util/PaimonCatalogUtils.scala: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kyuubi.engine.spark.util + +import java.lang.reflect.{InvocationTargetException, Method} +import java.util.Optional +import java.util.regex.Pattern + +import scala.collection.JavaConverters._ + +import org.apache.spark.sql.connector.catalog.{CatalogPlugin, Identifier} + +/** Access Paimon's optional view interface without a runtime dependency on Paimon. */ +private[spark] object PaimonCatalogUtils { + private val SUPPORT_VIEW = "org.apache.paimon.spark.catalog.SupportView" Review Comment: Thanks for pointing this out. I’ll rework this PR into generic GetTables support for Spark’s standard ViewCatalog, removing the Paimon-specific adapter and test setup. I’ll build the Spark 4.2 connector from the Iceberg 1.12.0 sources and manually verify JDBC table/view metadata against Spark 4.2, alongside generic regression tests. I’ll document the exact source revision, build steps, and validation results in the updated PR description. I’ll also update the title and scope to make clear that the original Spark 3.5 / Paimon reproduction remains unresolved pending Paimon’s migration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
