pan3793 commented on PR #7714:
URL: https://github.com/apache/kyuubi/pull/7714#issuecomment-5628976489
Re-checked the new revision, CI is green.
Two small things on the Kubernetes additions:
1. Please drop `spark.kubernetes.authenticate.driver.oauthTokenFile`: it is
not read by Spark
(checked 3.5, 4.3 and master). The driver only supports the inline
`spark.kubernetes.authenticate.driver.oauthToken`; a file form exists
only as
`...driver.mounted.oauthTokenFile`, which is a path inside the pod. My
earlier suggestion was
imprecise on this one - sorry. The other three (`caCertFile`,
`clientKeyFile`, `clientCertFile`)
are exactly right.
2. The new source bullet does not match these entries:
`SparkKubernetesClientFactory
::createKubernetesClient` reads the files with the prefix passed by the
caller (submission:
`spark.kubernetes.authenticate.submission`, driver: `...driver.mounted` /
client mode:
`spark.kubernetes.authenticate`). The non-mounted `driver.*File` keys
added here are read by
`DriverKubernetesCredentialsFeatureStep::configurePod` - please cite that
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
