LuciferYang commented on code in PR #7689:
URL: https://github.com/apache/kyuubi/pull/7689#discussion_r3931900820
##########
kyuubi-util/src/main/java/org/apache/kyuubi/util/reflect/DynMethods.java:
##########
@@ -343,14 +343,29 @@ public Builder ctorImpl(Class<?> targetClass, Class<?>...
argClasses) {
return this;
}
+ /**
+ * Checks for a constructor implementation, first finding the given class
by name using this
+ * builder's {@link ClassLoader}.
+ *
+ * <p>Neither upstream copy forwarded the loader to the inner constructor
builder, so the name
+ * resolved through the thread context loader regardless of what the
caller configured.
+ * parquet-common still resolves it that way; iceberg removed {@code
ctorImpl} altogether in
Review Comment:
Dropped, the iceberg link stays. Same reason applies to a clause in #7706's
class javadoc that claimed this copy reports candidates unlike either upstream,
so I removed that one too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
