maomaodev opened a new pull request, #7713:
URL: https://github.com/apache/kyuubi/pull/7713
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://kyuubi.readthedocs.io/en/master/contributing/code/index.html
2. If the PR is related to an issue in
https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title,
e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new feature, clarify the use cases.
2. If you fix a bug, you can clarify why it is a bug, and what versions
are affected.
-->
Kyuubi currently cannot discover or connect to server/engine endpoints in
IPv6-only clusters. Both the server side
(`DiscoveryClient.parseInstanceHostPort`) and the standalone JDBC client side
(`ZooKeeperHiveClientHelper`) parse a `host:port` string by naively splitting
on `":"`. This breaks for IPv6 because IPv6 addresses themselves contain `:`.
The correct parsing behavior already exists upstream in Hive
(`org.apache.hadoop.hive.common.IPStackUtils`). This patch mirrors that logic
in a new lightweight `IPStackUtils` utility under `kyuubi-util`, so it can be
shared between the server side and the standalone JDBC client (which only
depends on `kyuubi-util`).
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
- Added `IPStackUtilsTest` (11 test cases) aligned with Hive's own
[IPStackUtilsTest](https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/IPStackUtils.java),
covering IPv4, IPv6 with brackets, IPv6 without brackets, hostname, invalid
port, missing port, missing host and port range validation.
- Extended `DiscoveryClientSuite` with IPv6 cases (with and without
brackets) and converted it from an orphan trait to a runnable class.
### Was this patch assisted by generative AI tooling?
<!--
If generative AI tooling has assisted in authoring or reviewing this patch,
please include
an 'Assisted-by: ' trailer that identifies the agent and/or model.
For example: 'Assisted-by: Claude Opus 4.7' or 'Assisted-by:
Claude:claude-opus-4-7'.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Assisted-by: DeepSeek-V4-Pro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
